Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add max withdraw and max deposit validations #652

Merged

Conversation

halaprix
Copy link
Member

Ticket URL

Please provide a link to the ticket:

Description of Changes

Please list the changes introduced by this PR:

  • add validation for max withdraw
  • add validation for max deposit

How to Test

Please provide instructions on how to test the changes in this PR:

PR Definition of Done

Please ensure the following requirements have been met before marking the PR as ready for review:

  • All checks are passing
  • PR is linked to a corresponding ticket
  • PR title is clear and concise
  • Code has been self-reviewed and any fixes or improvements noted (See Code review standards in Notion)
  • Documentation has been updated if necessary

Copy link

This pull request has been linked to Shortcut Story #14924: [BUG] - Withdrawing input field is not validated.

@halaprix halaprix merged commit b1384b5 into dev Mar 21, 2024
2 checks passed
@halaprix halaprix deleted the js/sc-14924/bug-withdrawing-input-field-is-not-validated branch March 21, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants