Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix fee calculations and swap prices #668

Merged
merged 4 commits into from
Apr 5, 2024
Merged

fix: fix fee calculations and swap prices #668

merged 4 commits into from
Apr 5, 2024

Conversation

halaprix
Copy link
Member

@halaprix halaprix commented Apr 4, 2024 •
edited
Loading

Ticket URL

Please provide a link to the ticket:

Description of Changes

Please list the changes introduced by this PR:

  • stop using ETH as base for the price calculations
  • use debt token as base for price calculation
  • prices are canceled out in calculateNeededCollateralToPaybackDebt

How to Test

Please provide instructions on how to test the changes in this PR:

PR Definition of Done

Please ensure the following requirements have been met before marking the PR as ready for review:

  • All checks are passing
  • PR is linked to a corresponding ticket
  • PR title is clear and concise
  • Code has been self-reviewed and any fixes or improvements noted (See Code review standards in Notion)
  • Documentation has been updated if necessary

@shortcut-integration Shortcut Integration
Copy link

This pull request has been linked to Shortcut Story #15055: [BUG] - Morpho Blue & AJNA - sUSDe/DAI - Closing to sUSDe - Most of the value returned in DAI & position cannot be closed depending on current LTV (sUSDe to be returned is negative).

@halaprix halaprix changed the title fix: fix fees fix: fix fee calculations and swap prices Apr 4, 2024
zerotucks
zerotucks approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@zerotucks zerotucks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 Already discussed offline

@halaprix halaprix merged commit de4187a into dev Apr 5, 2024
2 checks passed
@halaprix halaprix deleted the kk/sc-15055/bug-morpho-blue-ajna-susde-dai-closing-to branch April 5, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerotucks zerotucks zerotucks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@halaprix @zerotucks