-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test suite tooling #1704
Merged
Merged
Test suite tooling #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It could be replaced with a simpler fieldset without breaking tests
Args in tests should be used for params and fixtures
erikvansebille
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the test suite is quite disconnected, where each test module is self reliant to generate its own Fields/FieldSets and fixtures for testing.
This PR introduces tooling via the
tests.utils
andtests.common_kernels
modules for the sharing of code (utility functions, kernels, and test data generation) between tests. This has multiple benefits:Field.from_data()
aren't necessary in most cases. Also helping readabilityOther changes:
Further refactoring of tests - including the use of common fieldsets, and creating global fixtures in a
conftest.py
- can be done in future in a piecemeal approach as needed.Related to #1684