feat: Add v1 publicActionsChildChain #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrstph-dvx
changed the title
fionnachan
reviewed
Jul 1, 2024
| * transport: http(), | ||
| * }).extend(publicActionsChildChain()) | ||
| * | ||
| * const isAChainOwner = await publicClientChildChain.isChainOwner({ address: zeroAddress }) |
There was a problem hiding this comment.
i know this is only an example but isAChainOwner deeply irritates me
can we change it to isChainOwner instead?
chrstph-dvx
force-pushed
the
add-publicActionsChildChain
branch
from
32775b3
to
9ecff00
Compare
chrstph-dvx
force-pushed
the
add-upgradeexecutor-setters
branch
from
6ad97ef
to
ebc9d22
Compare
chrstph-dvx
force-pushed
the
add-upgradeexecutor-setters
branch
from
ebc9d22
to
6c8eef6
Compare
chrstph-dvx
force-pushed
the
add-publicActionsChildChain
branch
from
9ecff00
to
3b85bbd
Compare
chrstph-dvx
force-pushed
the
add-upgradeexecutor-setters
branch
from
6c8eef6
to
a8bab3b
Compare
chrstph-dvx
force-pushed
the
add-publicActionsChildChain
branch
2 times, most recently
from
3b85bbd
to
3ca500f
Compare
chrstph-dvx
force-pushed
the
add-upgradeexecutor-setters
branch
2 times, most recently
from
56dfe8e
to
a826bac
Compare
chrstph-dvx
force-pushed
the
add-publicActionsChildChain
branch
from
3ca500f
to
95231a3
Compare
chrstph-dvx
force-pushed
the
add-publicActionsChildChain
branch
from
95231a3
to
3bb4a5f
Compare
chrstph-dvx
force-pushed
the
add-upgradeexecutor-setters
branch
from
a826bac
to
63f103e
Compare
Base automatically changed from
add-upgradeexecutor-setters
to
create-parent-chain-public-decorator
July 10, 2024 16:52
chrstph-dvx
merged commit 3bb4a5f
into
create-parent-chain-public-decorator
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SequencerInbox
Getters: #114
Setters: #117
Decorator: #119
RollupAdminLogic
Getters: #132
Settters: #133
ArbOwnerPublic
Getters #134
Setters #135
ArbGasInfo
Getters #136
UpgradeExecutor
Getters #137
Setters #138