fix: properly set callvalue in create rollup #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spsjvc
changed the title
spsjvc
force-pushed
the
test-add-assertion
branch
from
1e564f1
to
142f80d
Compare
spsjvc
force-pushed
the
test-add-assertion
branch
2 times, most recently
from
514d388
to
4fe0adb
Compare
spsjvc
force-pushed
the
test-add-assertion
branch
from
4fe0adb
to
3d9fe08
Compare
TucksonDev
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
createRollupGetCallValuewas being called without applying defaults, which meansparams.deployFactoriesToL2was set tofalse(even though are defaults set it totrue) so the call value was always 0.Now we properly apply defaults to input params first.
I also added one extra assertion to make sure everything was executed properly and the logs can be successfully decoded.
The test failing in CI should be ignored as it's not set up properly, and should be tried out locally.