Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add createRollupFetchTransactionHash #30

Merged
merged 14 commits into from
Jan 24, 2024

Conversation

TucksonDev
Copy link
Contributor

This PR adds the function createRollupFetchTransactionHash to src/createRollupFetchTransactionHash.ts. This function retrieves the transaction hash that created the specified rollup, so it can later be used with prepareTransaction or prepareTransactionReceipt. It includes a test with a deployed rollup chain. Closes #18 .

Doubts:

  • Do we want to include the Arbitrum SDK as a dependency to read the ABIs from there?

Copy link
Member

@spsjvc spsjvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! left a few comments

src/createRollupFetchTransactionHash.ts Outdated Show resolved Hide resolved
src/createRollupFetchTransactionHash.ts Outdated Show resolved Hide resolved
src/createRollup.unit.test.ts Outdated Show resolved Hide resolved
src/createRollupFetchTransactionHash.ts Outdated Show resolved Hide resolved
@spsjvc spsjvc self-requested a review January 24, 2024 12:16
Copy link
Member

@spsjvc spsjvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

@spsjvc spsjvc merged commit b7b0c4f into main Jan 24, 2024
5 checks passed
@spsjvc spsjvc deleted the feat-add-createrollupfetchtransactionhash branch January 24, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add createRollupFetchTransactionHash
2 participants