Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove skipped tests #389

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Remove skipped tests #389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 0 additions & 46 deletions chain-abstraction/sol-implementation/edge_challenge_manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,25 +159,6 @@ func TestEdgeChallengeManager_BlockChallengeAddLevelZeroEdge(t *testing.T) {
challengeManager, err := chain1.SpecChallengeManager(ctx)
require.NoError(t, err)

t.Run("claim predecessor does not exist", func(t *testing.T) {
t.Skip("Needs Solidity code")
})
t.Run("invalid height", func(t *testing.T) {
t.Skip("Needs Solidity code")
})
t.Run("last state is not assertion claim block hash", func(t *testing.T) {
t.Skip("Needs Solidity code")
})
t.Run("winner already declared", func(t *testing.T) {
t.Skip("Needs Solidity code")
})
t.Run("last state not in history", func(t *testing.T) {
t.Skip("Needs Solidity code")
})
t.Run("first state not in history", func(t *testing.T) {
t.Skip("Needs Solidity code")
})

leaves := make([]common.Hash, 4)
for i := range leaves {
leaves[i] = crypto.Keccak256Hash([]byte(fmt.Sprintf("%d", i)))
Expand Down Expand Up @@ -205,15 +186,6 @@ func TestEdgeChallengeManager_Bisect(t *testing.T) {
honestStateManager := bisectionScenario.honestStateManager
honestEdge := bisectionScenario.honestLevelZeroEdge

t.Run("cannot bisect unrivaled", func(t *testing.T) {
t.Skip("TODO(RJ): Implement")
})
t.Run("invalid prefix proof", func(t *testing.T) {
t.Skip("TODO(RJ): Implement")
})
t.Run("edge has children", func(t *testing.T) {
t.Skip("TODO(RJ): Implement")
})
t.Run("OK", func(t *testing.T) {
honestBisectCommit, err := honestStateManager.HistoryCommitmentUpToBatch(ctx, 0, challenge_testing.LevelZeroBlockEdgeHeight/2, 1)
require.NoError(t, err)
Expand All @@ -229,24 +201,6 @@ func TestEdgeChallengeManager_Bisect(t *testing.T) {
})
}

func TestEdgeChallengeManager_SubChallenges(t *testing.T) {
t.Run("leaf cannot be a fork candidate", func(t *testing.T) {
t.Skip("TODO(RJ): Implement")
})
t.Run("lowest height not one step fork", func(t *testing.T) {
t.Skip("TODO(RJ): Implement")
})
t.Run("has presumptive successor", func(t *testing.T) {
t.Skip("TODO(RJ): Implement")
})
t.Run("empty history root", func(t *testing.T) {
t.Skip("TODO(RJ): Implement")
})
t.Run("OK", func(t *testing.T) {
t.Skip("TODO(RJ): Implement")
})
}

func TestEdgeChallengeManager_ConfirmByOneStepProof(t *testing.T) {
ctx := context.Background()
t.Run("edge does not exist", func(t *testing.T) {
Expand Down
Loading