[2/3] - Add Virtual Support for Merkle Inclusion Proofs #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
force-pushed
the
replace-history-commits
branch
from
7d48859
to
64104a9
Compare
|
Ready again @potuz , the only copy that exists is essentially in rehashing the leaves passed into ComputeRoot now |
Primarily removing extraneous conditional logic, but also improving reuse of pre-calculated hashes for repeating layers where possible.
Especially remove some lingering duplicate checks, rearrange some conditionals to be more logical.
There was a confusingly inaccurate error message and some BUILD.bazel content that wasn't formatted the way gazelle wanted.
PlasmaPower
reviewed
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #681 , this PR adds support for virtual, Merkle inclusion proofs for the optimized implementation.