Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support seamless switchover redis for sequencer coordinator #2526

Merged
merged 16 commits into from
Oct 17, 2024
Merged

Support seamless switchover redis for sequencer coordinator #2526

merged 16 commits into from
Oct 17, 2024

Conversation

amsanghi
Copy link
Contributor

@amsanghi amsanghi commented Jul 26, 2024 •
edited
Loading

fixes: NIT-2684

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jul 26, 2024
@amsanghi amsanghi marked this pull request as ready for review July 26, 2024 12:50
PlasmaPower
PlasmaPower requested changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should write the wants-lockout key to both instances, even before we switch over. As-is I'm worried there will be a small period of downtime or potential instability, because the new redis won't have a record of which sequencers are alive.

@amsanghi
Copy link
Contributor Author

amsanghi commented Aug 6, 2024

We should write the wants-lockout key to both instances, even before we switch over. As-is I'm worried there will be a small period of downtime or potential instability, because the new redis won't have a record of which sequencers are alive.

Done

PlasmaPower
PlasmaPower approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PlasmaPower
PlasmaPower requested changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, seems like the race CI caught a race in this PR https://github.com/OffchainLabs/nitro/actions/runs/10685327893/job/29617877251?pr=2526#step:24:16969

@amsanghi
Copy link
Contributor Author

amsanghi commented Oct 8, 2024

Actually, seems like the race CI caught a race in this PR https://github.com/OffchainLabs/nitro/actions/runs/10685327893/job/29617877251?pr=2526#step:24:16969

Fixed now.

PlasmaPower
PlasmaPower approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 3f019ad into master Oct 17, 2024
15 checks passed
@PlasmaPower PlasmaPower deleted the Redis_switch branch October 17, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlasmaPower PlasmaPower PlasmaPower approved these changes

Assignees
No one assigned
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amsanghi @PlasmaPower