-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace kilic/bls12-381 with gnark-crypto/ecc/bls12-381 #2629
base: gligneul/fix-update-gethpin-v1.14.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks correct to me, but I have a few recommended simplifications and test cases
I pushed up a fuzzer for the new impl vs the old impl to the |
Thanks for running the fuzzer on this, updated! |
The new impl is now panicking with You can also run the fuzzer yourself locally by checking out the |
Thanks for catching this, updated! Also started running fuzzer to see if it catches something new. |
Its failing with It cause the first byte is being set to mUncompressedInfinity in the new setup, any thoughts on how to handle this? |
I think that's a cofactor issue.. Maybe try calling |
Fixes : NIT-2721