Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More check-build tweaks #2746

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

More check-build tweaks #2746

wants to merge 2 commits into from
+9 −6

Conversation

joshuacolvin0
Copy link
Member

  • remove last usage of sudo
  • improve version tag messaging
  • cleanup informational messages

@joshuacolvin0
More check-build tweaks
38ff827 
* remove last usage of `sudo`
* improve version tag messaging
* cleanup informational messages
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Oct 18, 2024
tsahee
tsahee requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

scripts/check-build.sh
VERSION_TAG=$(git tag --points-at HEAD | sed '/-/!s/$/_/' | sort -rV | sed 's/_$//' | head -n 1 | grep ^ || git show -s --pretty=%D | sed 's/, /\n/g' | grep -v '^origin/' | grep -v '^grafted\|HEAD\|master\|main$' || echo "dev")
echo -e "${YELLOW}You are on the version tag: $VERSION_TAG${NC}"
VERSION_TAG=$(git tag --points-at HEAD | sed '/-/!s/$/_/' | sort -rV | sed 's/_$//' | head -n 1 | grep ^ || git show -s --pretty=%D | sed 's/, /\n/g' | grep -v '^origin/' | grep -v '^grafted\|HEAD\|master\|main$' || echo "")
if [[ -z "${VAR}" ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean {VERSION_TAG} ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsahee tsahee tsahee requested changes

@amsanghi amsanghi amsanghi approved these changes

@eljobe eljobe Awaiting requested review from eljobe

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuacolvin0 @tsahee @amsanghi