Skip to content

Commit

Permalink
⬇️ (package.json): downgrade @iframe-resizer/react to 5.1.4 due to co…
Browse files Browse the repository at this point in the history
…mpatibility issues

♻️ (unlock.liquid): remove inline styles for offline-unlock-button to clean up markup and improve maintainability
  • Loading branch information
sebpalluel committed Jul 15, 2024
1 parent c5f9dd2 commit 3830eec
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 29 deletions.
2 changes: 1 addition & 1 deletion extensions/offline-connect-src/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"build:staging": "vite build --mode staging"
},
"dependencies": {
"@iframe-resizer/react": "^5.1.5",
"@iframe-resizer/react": "5.1.4",
"@shopify/gate-context-client": "^1.0.1",
"@tanstack/react-query": "^5.24.1",
"@xstate/react": "^4.1.1",
Expand Down
18 changes: 0 additions & 18 deletions extensions/offline-connect/blocks/unlock.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -273,24 +273,6 @@
Sign up to our club
</button>
`;
// Add styles inline
var style = document.createElement('style');
style.textContent = `
.offline-unlock-button {
background-color: {{ block.settings.offline_primary_color }};
color: {{ block.settings.offline_secondary_color }};
border-radius: {{ block.settings.offline_border_radius }};
height: {{ block.settings.offline_button_height }};
font-size: {{ block.settings.offline_button_font_size }};
letter-spacing: {{ block.settings.offline_button_letter_spacing }};
padding: {{ block.settings.offline_button_padding }};
max-width: {{ block.settings.offline_max_width }};
font-family: {{ block.settings.offline_font_family }}, sans-serif;
}
`;
document.head.appendChild(style);
setupTriggerObserver();
{% endif %}
{% else %}
Expand Down
19 changes: 9 additions & 10 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 3830eec

Please sign in to comment.