Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addtional testing for network layer #78

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Addtional testing for network layer #78

wants to merge 2 commits into from

Conversation

TheMeinerLP
Copy link
Collaborator

No description provided.

@TheMeinerLP TheMeinerLP requested a review from a team as a code owner September 30, 2024 10:19
@TheMeinerLP TheMeinerLP marked this pull request as draft September 30, 2024 10:21
theEvilReaper
theEvilReaper requested changes Oct 1, 2024
View reviewed changes
Copy link

@theEvilReaper theEvilReaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes are required

src/test/java/net/minestom/server/network/packet/client/common/ClientKeepAlivePacketTest.java Outdated Show resolved Hide resolved
src/test/java/net/minestom/server/network/packet/client/common/ClientPingRequestPacketTest.java Outdated Show resolved Hide resolved
...et/minestom/server/network/packet/client/configuration/ClientSelectKnownPacksPacketTest.java Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theEvilReaper theEvilReaper theEvilReaper requested changes

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheMeinerLP @theEvilReaper