Skip to content

Commit

Permalink
Merge pull request #935 from OneSignal/android_compile_version_34
Browse files Browse the repository at this point in the history
set compileSdkVersion 34 to fix build errors
  • Loading branch information
jkasten2 authored Aug 19, 2024
2 parents 3739275 + e3de934 commit 7e921f0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ rootProject.allprojects {
apply plugin: 'com.android.library'

android {
compileSdkVersion 28
compileSdkVersion 34
// Condition for namespace compatibility in AGP <4.2
if (project.android.hasProperty("namespace")) {
namespace 'com.onesignal.flutter'
Expand Down
2 changes: 1 addition & 1 deletion example/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ apply plugin: 'com.android.application'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"

android {
compileSdkVersion 33
compileSdkVersion 34

lintOptions {
disable 'InvalidPackage'
Expand Down

0 comments on commit 7e921f0

Please sign in to comment.