Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refinements to CI action #595

Merged
merged 11 commits into from
Aug 1, 2023
Merged

Refinements to CI action #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
feb6bc9
Don't re-pull packages or fail on info messages
iAmWillShepherd Aug 29, 2022
5c0aa88
Address warning from static analysis
iAmWillShepherd Aug 29, 2022
5972213
Don't wrap string interpolated objects with braces
iAmWillShepherd Aug 29, 2022
b89d95b
Use isEmpty property instead of checking for null
iAmWillShepherd Aug 29, 2022
5dfbf5e
Get rid of unused imports
iAmWillShepherd Aug 29, 2022
f8a30b9
Formatting
iAmWillShepherd Aug 29, 2022
db0829e
Replace dry-run flag with one that actually exists
iAmWillShepherd Aug 29, 2022
3c9c5ee
Don't show contents of formatted files
iAmWillShepherd Aug 29, 2022
376dfb7
Display json object of changes
iAmWillShepherd Aug 29, 2022
f1c6f27
Format project
iAmWillShepherd Aug 29, 2022
9e69c69
Merge branch 'main' into workflows-for-everyone
emawby Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ jobs:
run: flutter pub get

- name: Static Analysis
run: flutter analyze
run: flutter analyze --no-pub --no-fatal-infos

- name: Ensure the Dart code is formatted correctly
run: flutter format --set-exit-if-changed --dry-run .
run: flutter format -o none --set-exit-if-changed .

- name: Run Flutter unit tests
run: flutter test
103 changes: 51 additions & 52 deletions example/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,28 +38,29 @@ class _MyAppState extends State<MyApp> {

OneSignal.shared
.setNotificationOpenedHandler((OSNotificationOpenedResult result) {
print('NOTIFICATION OPENED HANDLER CALLED WITH: ${result}');
this.setState(() {
_debugLabelString =
"Opened notification: \n${result.notification.jsonRepresentation().replaceAll("\\n", "\n")}";
print('NOTIFICATION OPENED HANDLER CALLED WITH: $result');
this.setState(() {
_debugLabelString =
"Opened notification: \n${result.notification.jsonRepresentation().replaceAll("\\n", "\n")}";
});
});

OneSignal.shared
.setNotificationWillShowInForegroundHandler((OSNotificationReceivedEvent event) {
print('FOREGROUND HANDLER CALLED WITH: ${event}');
/// Display Notification, send null to not display
event.complete(null);

this.setState(() {
_debugLabelString =
"Notification received in foreground notification: \n${event.notification.jsonRepresentation().replaceAll("\\n", "\n")}";
OneSignal.shared.setNotificationWillShowInForegroundHandler(
(OSNotificationReceivedEvent event) {
print('FOREGROUND HANDLER CALLED WITH: $event');

/// Display Notification, send null to not display
event.complete(null);

this.setState(() {
_debugLabelString =
"Notification received in foreground notification: \n${event.notification.jsonRepresentation().replaceAll("\\n", "\n")}";
});
});
});

OneSignal.shared
.setInAppMessageClickedHandler((OSInAppMessageAction action) {
this.setState(() {
this.setState(() {
_debugLabelString =
"In App Message Clicked: \n${action.jsonRepresentation().replaceAll("\\n", "\n")}";
});
Expand All @@ -79,8 +80,8 @@ class _MyAppState extends State<MyApp> {
print("EMAIL SUBSCRIPTION STATE CHANGED ${changes.jsonRepresentation()}");
});

OneSignal.shared.setSMSSubscriptionObserver(
(OSSMSSubscriptionStateChanges changes) {
OneSignal.shared
.setSMSSubscriptionObserver((OSSMSSubscriptionStateChanges changes) {
print("SMS SUBSCRIPTION STATE CHANGED ${changes.jsonRepresentation()}");
});

Expand All @@ -101,8 +102,7 @@ class _MyAppState extends State<MyApp> {
});

// NOTE: Replace with your own app ID from https://www.onesignal.com
await OneSignal.shared
.setAppId("380dc082-5231-4cc2-ab51-a03da5a0e4c2");
await OneSignal.shared.setAppId("380dc082-5231-4cc2-ab51-a03da5a0e4c2");

// iOS-only method to open launch URLs in Safari when set to false
OneSignal.shared.setLaunchURLsInApp(false);
Expand All @@ -121,13 +121,14 @@ class _MyAppState extends State<MyApp> {
// Some examples of how to use Outcome Events public methods with OneSignal SDK
oneSignalOutcomeEventsExamples();

bool userProvidedPrivacyConsent = await OneSignal.shared.userProvidedPrivacyConsent();
bool userProvidedPrivacyConsent =
await OneSignal.shared.userProvidedPrivacyConsent();
print("USER PROVIDED PRIVACY CONSENT: $userProvidedPrivacyConsent");
}

void _handleGetTags() {
OneSignal.shared.getTags().then((tags) {
if (tags == null) return;
if (tags.isEmpty) return;

setState((() {
_debugLabelString = "$tags";
Expand Down Expand Up @@ -168,7 +169,8 @@ class _MyAppState extends State<MyApp> {
OneSignal.shared.getDeviceState().then((deviceState) {
print("DeviceState: ${deviceState?.jsonRepresentation()}");
this.setState(() {
_debugLabelString = deviceState?.jsonRepresentation() ?? "Device state null";
_debugLabelString =
deviceState?.jsonRepresentation() ?? "Device state null";
});
});
}
Expand Down Expand Up @@ -207,7 +209,7 @@ class _MyAppState extends State<MyApp> {
});
}

void _handleSetSMSNumber() {
void _handleSetSMSNumber() {
if (_smsNumber == null) return;

print("Setting SMS Number");
Expand Down Expand Up @@ -265,29 +267,28 @@ class _MyAppState extends State<MyApp> {
if (_externalUserId == null) return;

OneSignal.shared.setExternalUserId(_externalUserId!).then((results) {
if (results == null) return;
if (results.isEmpty) return;

this.setState(() {
_debugLabelString = "External user id set: $results";
});
this.setState(() {
_debugLabelString = "External user id set: $results";
});
});
}

void _handleRemoveExternalUserId() {
OneSignal.shared.removeExternalUserId().then((results) {
if (results == null) return;
if (results.isEmpty) return;

this.setState(() {
_debugLabelString = "External user id removed: $results";
});
this.setState(() {
_debugLabelString = "External user id removed: $results";
});
});
}

void _handleSendNotification() async {
var deviceState = await OneSignal.shared.getDeviceState();

if (deviceState == null || deviceState.userId == null)
return;
if (deviceState == null || deviceState.userId == null) return;

var playerId = deviceState.userId!;

Expand Down Expand Up @@ -315,8 +316,7 @@ class _MyAppState extends State<MyApp> {
void _handleSendSilentNotification() async {
var deviceState = await OneSignal.shared.getDeviceState();

if (deviceState == null || deviceState.userId == null)
return;
if (deviceState == null || deviceState.userId == null) return;

var playerId = deviceState.userId!;

Expand Down Expand Up @@ -349,7 +349,8 @@ class _MyAppState extends State<MyApp> {
OneSignal.shared.removeTriggerForKey("trigger_2");

// Get the value for a trigger by its key
Object? triggerValue = await OneSignal.shared.getTriggerValueForKey("trigger_3");
Object? triggerValue =
await OneSignal.shared.getTriggerValueForKey("trigger_3");
print("'trigger_3' key trigger value: ${triggerValue?.toString()}");

// Create a list and bulk remove triggers based on keys supplied
Expand Down Expand Up @@ -384,8 +385,8 @@ class _MyAppState extends State<MyApp> {
}

Future<void> outcomeAwaitExample() async {
var outcomeEvent = await OneSignal.shared.sendOutcome("await_normal_1");
print(outcomeEvent.jsonRepresentation());
var outcomeEvent = await OneSignal.shared.sendOutcome("await_normal_1");
print(outcomeEvent.jsonRepresentation());
}

@override
Expand Down Expand Up @@ -414,10 +415,8 @@ class _MyAppState extends State<MyApp> {
_handlePromptForPushPermission, !_enableConsentButton)
]),
new TableRow(children: [
new OneSignalButton(
"Print Device State",
_handleGetDeviceState,
!_enableConsentButton)
new OneSignalButton("Print Device State",
_handleGetDeviceState, !_enableConsentButton)
]),
new TableRow(children: [
new TextField(
Expand Down Expand Up @@ -468,12 +467,12 @@ class _MyAppState extends State<MyApp> {
)
]),
new TableRow(children: [
new OneSignalButton(
"Set SMS Number", _handleSetSMSNumber, !_enableConsentButton)
new OneSignalButton("Set SMS Number", _handleSetSMSNumber,
!_enableConsentButton)
]),
new TableRow(children: [
new OneSignalButton("Logout SMS Number", _handleLogoutSMSNumber,
!_enableConsentButton)
new OneSignalButton("Logout SMS Number",
_handleLogoutSMSNumber, !_enableConsentButton)
]),
new TableRow(children: [
new OneSignalButton("Provide GDPR Consent", _handleConsent,
Expand Down Expand Up @@ -516,12 +515,12 @@ class _MyAppState extends State<MyApp> {
)
]),
new TableRow(children: [
new OneSignalButton(
"Set External User ID", _handleSetExternalUserId, !_enableConsentButton)
new OneSignalButton("Set External User ID",
_handleSetExternalUserId, !_enableConsentButton)
]),
new TableRow(children: [
new OneSignalButton(
"Remove External User ID", _handleRemoveExternalUserId, !_enableConsentButton)
new OneSignalButton("Remove External User ID",
_handleRemoveExternalUserId, !_enableConsentButton)
]),
new TableRow(children: [
new TextField(
Expand All @@ -544,8 +543,8 @@ class _MyAppState extends State<MyApp> {
)
]),
new TableRow(children: [
new OneSignalButton(
"Set Language", _handleSetLanguage, !_enableConsentButton)
new OneSignalButton("Set Language", _handleSetLanguage,
!_enableConsentButton)
]),
new TableRow(children: [
new Container(
Expand Down
Loading
Loading