Updated async attribute. #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated async attribute to correct implementation. This change in version WordPress 6.3, to allow scripts to have async defer added when enqueueing: https://make.wordpress.org/core/2023/07/14/registering-scripts-with-async-and-defer-attributes-in-wordpress-6-3/ Original code causes issues for some folks whereby the src was added as src="https://cdn.onesignal.com/sdks/OneSignalSDK.js' async='async" causing a 404. Originally assumed to be CDn/Optimise type plugin problem.
jkasten2
approved these changes
Dec 11, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated async attribute to correct implementation.
This change in version WordPress 6.3, to allow scripts to have async defer added when enqueueing: https://make.wordpress.org/core/2023/07/14/registering-scripts-with-async-and-defer-attributes-in-wordpress-6-3/
Original code causes issues for some folks whereby the src was added as src="https://cdn.onesignal.com/sdks/OneSignalSDK.js' async='async" causing a 404. Originally assumed to be CDn/Optimise type plugin problem.
This change is