Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin Prop Validation & Improvements #201

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Plugin Prop Validation & Improvements #201

merged 4 commits into from
Sep 27, 2023

Commits on Sep 26, 2023

  1. Check that plugin props are being provided 

    Motivation: the property "mode" is required. Currently, because we don't check for this, nodejs is throwing a runtime error when trying to access smallIcons (optional prop) when the props object is undefined.

This is confusing for folks who first set up and try running without setting a props object to the plugin array.

Clear error message will be much more helpful.
    @rgomezp
    rgomezp committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    c1051c3 View commit details
    Browse the repository at this point in the history

  2. Plugin props validation 

    Motivation: we can provide better error messages by throwing when the user provides props of the wrong type or not in the model
    @rgomezp
    rgomezp committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    1d92b56 View commit details
    Browse the repository at this point in the history

  3. Correct type definition 

    Motivation: devTeam & iPhoneDeploymentTarget are optional.
    @rgomezp
    rgomezp committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    3e64f79 View commit details
    Browse the repository at this point in the history

  4. 2.0.1 Version Release 

    Update version in package.json
    @rgomezp
    rgomezp committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    c28407f View commit details
    Browse the repository at this point in the history