Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openwrt 18.06 ubuntu 20.04 #29

Open
wants to merge 3 commits into
base: openwrt-18.06
Choose a base branch
from

Conversation

chmorgan
Copy link

Upgrade the image from ubuntu 18.06 to 20.04 so newer packages are available when building packages.

Hi @greenbreakfast. I'm not sure if this makes sense to merge in without more testing, or maybe not at all, I'll be testing more here to see how it builds packages, but a minimal build does complete successfully here. I'll be trying building and running some packages.

@greenbreakfast
Copy link

greenbreakfast commented Jul 16, 2021

Hi @chmorgan, I'm hesitant to merge these commits in.
What benefit do we get from moving the dockerfile up to ubuntu 20.04?

And am I correct in understanding the kernel patch removal is because of the kernel changes in ubuntu 20.04?
If so, that's cause for concern since it might mean a cascade of other things to debug because of the OS change.

The build system is working well at the moment, I'm leaning towards "if it ain't broke, don't fix it"

If you need these changes for something specific, you're welcome to make a fork of the repo and make these changes in the fork. It should be easy to keep up with this repo going forward if those are the only changes.

@chmorgan
Copy link
Author

Bah. my comment was lost when I changed windows.

I was looking to update because a bunch of npm libraries require versions of node newer than that in 18.06.

Working the other way, should I instead be using 21.02? It doesn't look like anyone has setup a docker file for this branch but I could do that and test to see how it might work. Is there a plan to release a 21.02 based system when 21.02 is officially released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants