Skip to content

Commit

Permalink
Merge pull request #16 from Onix-Systems/release/1.0.0
Browse files Browse the repository at this point in the history
Release 1.0.0 to master
  • Loading branch information
vitalka-s authored Dec 6, 2016
2 parents 85163a1 + 4e6756f commit 5d8f7df
Show file tree
Hide file tree
Showing 1,093 changed files with 2,301 additions and 41,582 deletions.
81 changes: 81 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
# Contributing - How we add to the product

## General

* Each message (issue, commit, pull request) starts with a verb
* Each message starts with an uppercase and doesn't end with a period
* Each message starts with a line that is less than 80 characters long

**Examples:**

* _Design login workflow_
* _Update to latest version of Play tools_
* _Improve display of CI failures_


## Issues

* Each issue represents a single problem
* Each issue has a milestone attached

## Milestones

* Each milestone needs to match one of the following patterns:
* semantic version number (`1.0`, `1.0.5`)
* semantic version number with a wildcard (`2.x`, `2.1.x`)
* `undecided` - issues we want to keep, but aren't sure when we'll address
* `invalid` - issues that were duplicate, invalid (or similar) go here to avoid upsetting milestone counts

# Versioning

## Commits

* Each commit represents a single change
* Each commit keeps the project fully functional
* Each commit message that closes an issue ends with `(close #XYZ)`

**Examples:**

* _Design login workflow (close #1)_
* _Fix typo in about dialog_
* _Document data model accessors (close #3, close #4)_

## Pull requests

* Each pull request represents a single problem
* Each pull request has a milestone attached
* Each pull request contains as few commits as needed
* Each pull request is rebased on latest `develop`
* Each pull request is free from fixup or revert commits

## Branches

* Use _true merge_ if it's desirable for the branch to remain visible in the long run
* Use _fast-forward merge_ for temporary branches

# Workflow

## Development

1. Create a feature branch `feature/xxx-yyy-zzz`
2. Make and commit changes
3. Create a pull request against `develop`
4. Go through code review
5. See your pull request merged

## Deployment

1. Branch out `release/X.Y.Z` from `develop`
2. Test the release
3. Merge the release branch to `master`
4. Tag the merge commit as `X.Y.Z`
5. Delete the release branch
6. Deploy from `master` branch

# Code

## General

1. No magic numbers in storyboards. To have space between views - use layout margins. To get even more space - use embed views.
1. Extention vs subclassing. Avoid subclassing and use protocols instead. One can [google](https://www.google.com.ua/search?client=safari&rls=en&q=swift+protocol+vs+subclass&ie=UTF-8&oe=UTF-8&gfe_rd=cr&ei=SjkHWKOKD5Gr8wfRv6OoDQ) about it or check [this](http://mikebuss.com/2016/01/10/interfaces-vs-inheritance/) artcile or [this](http://krakendev.io/blog/subclassing-can-suck-and-heres-why) or even [this](https://www.natashatherobot.com/swift-2-0-protocol-oriented-mvvm/).
1. Use `NSLocalizedString` for all strings visible to user.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
4 changes: 2 additions & 2 deletions VideoEditor2/Pods/MBProgressHUD/LICENSE → LICENSE
100644 → 100755
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Copyright (c) 2013 Matej Bukovinski
Copyright (c) 2016 Onix-Systems

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand All @@ -16,4 +16,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.
THE SOFTWARE.
520 changes: 0 additions & 520 deletions MediaComposerDemo.xcodeproj/project.pbxproj

This file was deleted.

This file was deleted.

This file was deleted.

Binary file not shown.
Binary file not shown.

This file was deleted.

This file was deleted.

Loading

0 comments on commit 5d8f7df

Please sign in to comment.