-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDB-6329 - Hide toastr and info messages when license invalid #1380
base: master
Are you sure you want to change the base?
Conversation
74d03b6
to
1be4c29
Compare
Jenkins retry build |
There are some other places where the toastr notification is shown or an action which requires a valid license leads to an error.
|
3c184b7
to
48e7cb6
Compare
src/js/angular/graphexplore/controllers/graphs-visualizations.controller.js
Outdated
Show resolved
Hide resolved
src/js/angular/graphexplore/controllers/rdf-class-hierarchy.controller.js
Outdated
Show resolved
Hide resolved
src/js/angular/graphexplore/controllers/rdf-class-hierarchy.controller.js
Outdated
Show resolved
Hide resolved
src/js/angular/graphexplore/directives/rdf-class-hierarchy.directive.js
Outdated
Show resolved
Hide resolved
These are valid notes also and should be fixed! |
d69dc4c
to
b70553e
Compare
… license service in templates and controllers.
… repo is selected
b70553e
to
6e6aaaa
Compare
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
What?
When the license is invalid all views that need to send SPARQL queries to work will show a 'license expired' message. No toastr messages or warnings will appear.
Why?
The message is added to inform the user, in the clearest way possible, to update their license in order to regain functionality.
How?
I added the error template and license validity checks, where necessary.
Testing?
Some tests updated.
Screenshots?