-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proxy configuration to enable communication for all microfrontends. #1459
Open
boyan-tonchev
wants to merge
11
commits into
GDB-10373-workbench-single-spa
Choose a base branch
from
GDB-10373-configure-proxy-for-all-microfrond-ends
base: GDB-10373-workbench-single-spa
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add proxy configuration to enable communication for all microfrontends. #1459
boyan-tonchev
wants to merge
11
commits into
GDB-10373-workbench-single-spa
from
GDB-10373-configure-proxy-for-all-microfrond-ends
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade of webpack to latest version 5 which we need as precondition for running module federation. * Upgraded webpack and webpack-cli * Upgraded all used webpack plugins and loaders * Changed the legacy workbench to be single spa module * Added build scripts * Switch order of main and vendor bundles import as this affects the css order that is important. Removed hardcoded rest url. * Add some minor adjustments in formating and added test navigation links that work in different ways - these will be changed later. --------- Co-authored-by: boyantonchev <[email protected]>
* Add shared api module to the project * add the package.json with the updated start command * Add installation script for the `api` module as well as a build script which is run in the postinstall phase. * Changed the title in the index html. Removed the single-spa/welcome application from the import map. Moved the workbench-api application in the separate import map which is used for the shared stuff only. * updated the package-lock.json
* Add navbar MF * Register the navbar MF * Fix legacy-workbench app mounting in proper place in the DOM. Previously it was attached to the body, now it is inside the main where the single spa includes it by default. * Fix some style issues * navbar project is added in the build, clean and install scripts * Extract separate script for building the api module. Fixed the legacy-workbench module initialization to prevent cyclic reinitialization of the workbench.
boyan-tonchev
force-pushed
the
GDB-10373-configure-proxy-for-all-microfrond-ends
branch
from
July 8, 2024 06:36
c0b1810
to
b0a3c2b
Compare
boyan-tonchev
force-pushed
the
GDB-10373-configure-proxy-for-all-microfrond-ends
branch
from
July 8, 2024 06:59
b0a3c2b
to
e77f23e
Compare
boyan-tonchev
force-pushed
the
GDB-10373-workbench-single-spa
branch
from
August 5, 2024 11:41
991bb9b
to
1e20cb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proxy configuration to enable communication for all microfrontends.