GDB-10692 - Change toggle behavior of import checkbox #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/js/angular/import/directives/import-resource-tree.directive.js
Outdated
Show resolved
Hide resolved
|
There should be some padding between the dropdown menu and the next button. Right now they are stuck to each other. |
src/js/angular/import/directives/import-resource-tree.directive.js
Outdated
Show resolved
Hide resolved
src/js/angular/import/directives/import-resource-tree.directive.js
Outdated
Show resolved
Hide resolved
|
Can you style the cursor when it's over checkboxexto be like a pointer? |
src/js/angular/import/directives/import-resource-tree.directive.js
Outdated
Show resolved
Hide resolved
src/js/angular/import/directives/import-resource-tree.directive.js
Outdated
Show resolved
Hide resolved
src/js/angular/import/directives/import-resource-tree.directive.js
Outdated
Show resolved
Hide resolved
…o make the checkbox look like the dropdown button.
…ue: main checkbox goes out of sync with list after indeterminate click
DesiBorisova
force-pushed
the
GDB-10692-import-checkbox-improvement
branch
from
f31535d to
4e35494
Compare
src/js/angular/import/directives/import-resource-tree.directive.js
Outdated
Show resolved
Hide resolved
src/js/angular/models/import/checkbox-control-resource-wrapper.js
Outdated
Show resolved
Hide resolved
src/js/angular/import/directives/import-resource-tree.directive.js
Outdated
Show resolved
Hide resolved
src/js/angular/import/directives/import-resource-tree.directive.js
Outdated
Show resolved
Hide resolved
…tor wrapper class. Introduce test
src/js/angular/models/import/checkbox-control-resource-wrapper.js
Outdated
Show resolved
Hide resolved
…urceTreeElement class
src/js/angular/import/directives/import-resource-tree.directive.js
Outdated
Show resolved
Hide resolved
src/js/angular/import/directives/import-resource-tree.directive.js
Outdated
Show resolved
Hide resolved
src/js/angular/import/directives/import-resource-tree.directive.js
Outdated
Show resolved
Hide resolved
…portResourceTreeElement class" This reverts commit 03426f7.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The way the checkbox and drop-down in the Import page works will be as follows:
When the user selects the checkbox next to the drop-down, all files will be selected.
When the user deselects the checkbox next to the drop-down, all files will be deselected.
When the user clicks the checkbox next to the drop-down while it is indeterminate, all files will be deselected.
Selecting from the drop-down ("All", "None", "Imported", "Not imported") will not show the selected option next to the checkbox drop-down. Only the applicable files will be checked in the list.
Manually selecting all the files will check the checkbox by the drop-down list.
Manually deselecting all the files will uncheck the checkbox by the drop-down list.
Why
This behavior was agreed with our UX specialist and matches the prototype in the task comment. The behavior is more intuitive for users, as it closely matches the Gmail email list checkbox drop-down.
How
I added logic to switch the checkbox states, depending on the conditions. I refactored the directive and added a wrapper class for the resource list. I edited the styles, so that the independent checkbox can appear as part of the button as before.
Testing
Test added for this functionality.
Screenshots
Checklist