Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename securing mechanism to OpenAttestationHashProof2018 #316

Open
wants to merge 1 commit into
base: beta
Choose a base branch
from

Conversation

cxcheng
Copy link

@cxcheng cxcheng commented Oct 22, 2024

Summary

The name change is to be done before OA v4 rollout. The reason is that the team feels that the original name of OpenAttestationMerkleProofSignature2018 does not correctly reflect that we are not using a Merkle Tree structure within a document. We are only doing it for a batch of OA documents. We feel we want to more accurately reflect this in our communications with the external world, particularly the W3C.

Changes

Only changes done is a global search and replace of OpenAttestationMerkleProofSignature2018 to OpenAttestationHashProof2018.

Issues

None

@cxcheng cxcheng requested a review from HJunyuan October 22, 2024 07:05
@cxcheng cxcheng self-assigned this Oct 22, 2024
@cxcheng cxcheng changed the title Rename securing mechanism name from OpenAttestationMerkleProofSignature2018 to OpenAttestationHashProof2018 Rename securing mechanism to OpenAttestationHashProof2018 Oct 22, 2024
@HJunyuan HJunyuan changed the title Rename securing mechanism to OpenAttestationHashProof2018 chore: rename securing mechanism to OpenAttestationHashProof2018 Oct 23, 2024
@HJunyuan HJunyuan marked this pull request as draft October 23, 2024 04:59
@HJunyuan HJunyuan marked this pull request as ready for review October 23, 2024 04:59
@HJunyuan HJunyuan force-pushed the chore/rename-to-OpenAttestationHashProof2018 branch from 2c18ece to 0417f06 Compare October 23, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants