basic plus extra fields #883
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemilonkh
approved these changes
Nov 7, 2024
| @@ -233,7 +222,7 @@ const ActivityModalBody = ({ | |||
| {f.options && ( | |||
| <FormControl key={idx} className="w-full"> | |||
| <BuildingTypeSelectInput | |||
| options={f.options} | |||
| options={f.options as string[]} | |||
There was a problem hiding this comment.
I think we need to map or change the data type of this property here if the data is in a different format now?
| @@ -25,7 +25,7 @@ export function findMethodology( | |||
| export interface ExtraField { | |||
| id: string; | |||
| type?: string; | |||
| options?: string[]; | |||
| options?: string[] | { type: string; names: string[] }[]; | |||
There was a problem hiding this comment.
Ideally we only have one of these and rework the existing data to also use this schema. Otherwise we need to have an if/ else block for both cases in every place this is used...
There was a problem hiding this comment.
We could potentially have a helper function that normalizes it, but at that point let's just use my automatic rewriting script for the JSON and fix all of the data types to be consistent.
|
let's not merge this until we meet with Evan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR related with MI extra fields for "direct measure" methodology for scope 3 (stationary energy and transportation), IPPU and AFOLU.