Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update masthead illustration #20

Conversation

jesicasusanto
Copy link
Collaborator

@jesicasusanto jesicasusanto commented Jun 16, 2023

This PR resolves #17 . This PR updates the masthead illustration to be the desired illustration.

Before :

image

After :

image

@netlify
Copy link

netlify bot commented Jun 16, 2023

Deploy Preview for cosmic-klepon-3c693c failed.

Name Link
🔨 Latest commit 0ded96a
🔍 Latest deploy log https://app.netlify.com/sites/cosmic-klepon-3c693c/deploys/64998756666df800083099c4

@jesicasusanto jesicasusanto changed the title add robot hand svg update masthead illustration Jun 16, 2023
@abrichr
Copy link
Member

abrichr commented Jun 16, 2023

Thanks @jesicasusanto ! Here is what I see at https://deploy-preview-20--cosmic-klepon-3c693c.netlify.app/:

image

If this is a draft can you please mark it as such? 🙏

@jesicasusanto jesicasusanto marked this pull request as draft June 19, 2023 01:41
@jesicasusanto
Copy link
Collaborator Author

@abrichr yes, done!

@jesicasusanto jesicasusanto marked this pull request as ready for review June 19, 2023 12:26
@jesicasusanto
Copy link
Collaborator Author

Hi @abrichr , this PR is ready for review. Thank you!

@jesicasusanto
Copy link
Collaborator Author

I added left margin to the icon to center it above the box (7c44b96) @abrichr Please let me know what you think. thank you.

Before
image
After
image

@abrichr
Copy link
Member

abrichr commented Jun 19, 2023

Great work @jesicasusanto !

What do you think about removing the box altogether? Also, what do you think about modifying the animations for each .svg slightly such that they don't all appear to be fixed together? In addition to position animations, we could also slightly animate the size of each by e.g. 10% in each direction

@jesicasusanto
Copy link
Collaborator Author

Hi @abrichr , This PR has deploying issue so I created a new PR at #28 . Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update masthead illustration
2 participants