Implementing Testimonial Section #47
Conversation
✅ Deploy Preview for cosmic-klepon-3c693c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yassataiseer
changed the title
|
Thank you @yassataiseer ! This is what I see at https://deploy-preview-47--cosmic-klepon-3c693c.netlify.app/: 
A few thoughts:
Just some thoughts. Please feel free to be a bit more creative with the styling/appearance (e.g. hover animations). Please also include the testimonial in the screenshot of the email in the description here: OpenAdaptAI/OpenAdapt#564 Thank you! |
|
Hi, thanks for the feedback! How should the text not be cut off? I do not want it to overflow, should I include some character count? Other feedback is being changed accordingly. The testimony in OpenAdaptAI/OpenAdapt#564 has its name cutoff. |
|
hi @abrichr I have implemented the following changes and attached a demo below.
I attempted to guess the name of the person who wrote the testimony here: OpenAdaptAI/OpenAdapt#564. Please let me know the actual name so i can fix it. 2024-03-14_19-12-07.mp4 |
|
Thank you @yassataiseer !
Ideally it should continue on the next line, and not end with an ellpisis (
Kibeom Kim |
components/Testimonies.module.css
Outdated
| @@ -0,0 +1,96 @@ | |||
| .header{ | |||
components/Testimonies.js
Outdated
| import { faWindows, faApple } from '@fortawesome/free-brands-svg-icons'; | ||
| import styles from './Testimonies.module.css'; | ||
|
|
||
| export default function Testimonies() { |
There was a problem hiding this comment.
Please rename to "Testimonials"
components/Testimonies.js
Outdated
| import styles from './Testimonies.module.css'; | ||
|
|
||
| export default function Testimonies() { | ||
| const TestimonyData = [ |
There was a problem hiding this comment.
Please use lowerCamelCase for variables as per https://google.github.io/styleguide/tsguide.html#naming-rules-by-identifier-type
components/Testimonies.js
Outdated
| <br> | ||
| Anyway I'm very happy to get here thanks to OpenAdapter! | ||
| <br> | ||
| <br> |
There was a problem hiding this comment.
Please use <p> instead of <br/>
…me, css headers and renamed react component
|
Alright made the following fixes:
|
My current changes to this repository involve developing the testimonial section of the website I have attached a video demo below.
2024-03-09_04-06-23.mp4