Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nature Communications citation to welcome window #2260

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jtschwar
Copy link
Collaborator

Please provide an overview of what this pull request does, and reference any
relevant issues that are addressed. Once submitted you are encouraged to seek
review of the code, and to check the continuous integration results.

By submitting this pull request I agree to the terms of the
Developer Certificate or Origin.

@jtschwar jtschwar requested review from cjh1 and cryos August 16, 2022 22:39
Copy link
Member

@cryos cryos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this belongs in the welcome dialog, and personally I think we should look as a group at how we want to ask for citations, probably offer a hyperlink to any DOIs. I think that the About dialog is more appropriate, I would still like to develop a full Tomviz paper as the preferred citation as we discussed during the SBIR I was the PI on when at Kitware but in its absence I see the motivation to promote this more.

@jtschwar
Copy link
Collaborator Author

jtschwar commented Aug 17, 2022

@cryos I'm not sure if the About dialog is the best location, there's still an issue where tomviz crashes from selecting this dialog on Mac operating systems ( #2214 )

@Hovden
Copy link
Contributor

Hovden commented Aug 17, 2022

@cryos I agree that we need a generic tomviz paper. Currently, it is important we accumulate citations for our existing manuscript (the 2-year citation count will influence future papers). We can swap them in the dialogue when the other manuscript is published. I am available to talk over the phone about writing the next paper.

@Hovden
Copy link
Contributor

Hovden commented Aug 24, 2022

Following up on this. Are we merging?

@cjh1
Copy link
Member

cjh1 commented Aug 24, 2022

@jtschwar Can you take a look at #2214 by build a development version of Tomviz and the running it in gdb, I am happy to provide help? Then we can locate where/why its crashing. At which point I think the about dialog is the correct location for this information.

@Hovden
Copy link
Contributor

Hovden commented Aug 24, 2022

@cryos Is this an easy bug you could resolve? Then add the citation to the about. Also, we purchased a CC license for the manuscript so we can distribute with tomviz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants