Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC customizations after December 1st, 2023 #2

Merged
merged 22 commits into from
Mar 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
eb58469
added: OC customized enketo-express-oc files (leaving app in broken s…
MartijnR Dec 1, 2023
9f52146
fixed most obvious build errors after migration of OC customizations
MartijnR Dec 1, 2023
d8902f7
revert a mistake
MartijnR Dec 1, 2023
b79c07e
changed: removed github actions and updated descriptions in package.json
MartijnR Dec 1, 2023
d3b56a4
changed: updated readme
MartijnR Dec 1, 2023
857dd8b
fixed: evaluator not included
MartijnR Dec 4, 2023
06034aa
fixed: eslint errors
MartijnR Dec 4, 2023
87d87ca
Fix: "for" attribute throws off ability to open to the right page upo…
MartijnR Dec 8, 2023
dea5b8a
Revert fix to preserve high fidelity data for annotations
lognaturel Jan 18, 2024
bc0c335
Use old version of signature pad
lognaturel Jan 22, 2024
0c29a15
Merge pull request #1292 from lognaturel/revert-annotate
lognaturel Jan 24, 2024
d5c81b7
Add warning about libxslt dependency (#823)
lognaturel Jan 24, 2024
5bab4d0
Update git links and author information (#1266)
lognaturel Jan 24, 2024
2f27f07
Prepare enketo-core 8.1.0 and enketo-express 7.1.0 (#1293)
lognaturel Jan 26, 2024
740bd23
Merge commit '2f27f07b9d72eb27fb8576570501682b2f3ca5d2' into oc-custo…
MartijnR Mar 5, 2024
5c7781a
moved fix https://github.com/OpenClinica/enketo-express-oc/commit/c47…
MartijnR Mar 5, 2024
05287ef
moved fix https://github.com/OpenClinica/enketo-express-oc/commit/bc7…
MartijnR Mar 5, 2024
950168b
moved fix https://github.com/OpenClinica/enketo-express-oc/commit/4a3…
MartijnR Mar 5, 2024
b8770e6
moved fix https://github.com/OpenClinica/enketo-express-oc/commit/0b7…
MartijnR Mar 5, 2024
a026355
moved fix https://github.com/OpenClinica/enketo-express-oc/commit/df2…
MartijnR Mar 5, 2024
c2cc657
moved fix https://github.com/OpenClinica/enketo-express-oc/commit/a6d…
MartijnR Mar 5, 2024
90e9630
fixed eslint errors
MartijnR Mar 5, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@

/packages/enketo-express/public/js/build/*
/packages/enketo-express/**/offline-app-worker-partial.js
/packages/enketo-express/test/client/forms/forms.js
3 changes: 2 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,8 @@
"files": [
"packages/enketo-express/public/**/*",
"packages/enketo-express/app/views/**/*.js",
"packages/enketo-express/test/client/**/*.js"
"packages/enketo-express/test/client/**/*.js",
"packages/enketo-express/widget/**/*"
],

"env": { "browser": true }
Expand Down
56 changes: 0 additions & 56 deletions .github/workflows/docker-hub.yml

This file was deleted.

50 changes: 0 additions & 50 deletions .github/workflows/ghcr.yml

This file was deleted.

1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ Thumbs.db
/.benchmarks.md
/examples/*/.benchmarks.md
/packages/*/.benchmarks.md
/packages/enketo-express/chromium-cache/*

# -----------------------------------------------------------------------------
# 5.4. Tooling - build artifacts
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Enketo

This is the Enketo web forms monorepo. Enketo is an open source project that produces web form software for the [ODK ecosystem](https://getodk.org).
This is the OpenClinica fork of the Enketo web forms monorepo. Enketo is an open source project that produces web form software for the [ODK ecosystem](https://getodk.org).

## Packages

Expand Down
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "enketo",
"description": "Enketo Web Forms",
"repository": "https://github.com/enketo/enketo",
"description": "Enketo Web Forms Fork for OpenClinica",
"repository": "https://github.com/OpenClinica/enketo-oc",
"private": true,
"workspaces": {
"packages": [
Expand Down Expand Up @@ -92,10 +92,10 @@
"sinon-chai": "^3.7.0",
"time-grunt": "^2.0.0",
"typescript": "^5.2.2",
"vite": "^4.4.9",
"vite-node": "^0.34.3",
"vite": "^4.5.2",
"vite-node": "^0.34.7",
"vite-plugin-node": "^3.0.2",
"vitest": "^0.34.3",
"vitest": "^0.34.6",
"webpack": "^5.88.2"
},
"resolutions": {
Expand Down
5 changes: 5 additions & 0 deletions packages/enketo-core/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [8.1.0] - 2024-01-25

- Fix: "for" attribute throws off ability to open to the right page upon load (#1286)
- Revert change from v7.2.0 to preserve high resolution annotated images (#1292)

## [8.0.0] - 2023-10-30

- Breaking change: in the move to a monorepo, some paths in Sass styles have been updated to reflect the new file structure. The impact should be minimal, but custom themes may need to be updated. Generally, paths which cross package boundaries (i.e. imports from Enketo Express to styles in Enketo Core, or imports of third party styles from NPM packages) should use absolute paths from the monorepo root. You may refer to existing theme styles for examples.
Expand Down
18 changes: 4 additions & 14 deletions packages/enketo-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "enketo-core",
"description": "Extensible Enketo form engine",
"homepage": "https://enketo.org",
"version": "8.0.0",
"version": "8.1.0",
"license": "Apache-2.0",
"os": [
"darwin",
Expand All @@ -18,23 +18,13 @@
],
"repository": {
"type": "git",
"url": "https://github.com/enketo/enketo-core"
"url": "https://github.com/enketo/enketo"
},
"author": {
"name": "Martijn van de Rijdt",
"email": "[email protected]",
"url": "https://www.linkedin.com/in/martijnvanderijdt"
},
"contributors": [
{
"name": "Alex Anderson"
}
],
"files": [
"src/",
"config.js"
],
"bugs": "https://github.com/enketo/enketo-core/issues",
"bugs": "https://github.com/enketo/enketo/issues",
"main": "src/js/form.js",
"scripts": {
"build": "grunt css && grunt compile && grunt transforms && echo 'enketo-core build complete'",
Expand Down Expand Up @@ -72,7 +62,7 @@
"mergexml": "1.2.3",
"node-forge": "^1.3.1",
"openrosa-xpath-evaluator": "3.0.0",
"signature_pad": "^4.1.6"
"signature_pad": "2.3.x"
},
"engines": {
"node": ">=18 <21",
Expand Down
10 changes: 5 additions & 5 deletions packages/enketo-core/src/js/page.js
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,12 @@ export default {
*/
flipToPageContaining($e) {
const e = $e[0];
const closest = e.closest('[role="page"]');
const closestPage = e.closest('[role="page"]');

if (closest) {
this._flipTo(closest);
} else {
// If $e is a comment question, and it is not inside a group, there will be no closest.
if (closestPage) {
this._flipTo(closestPage);
} else if (e.closest('.question')) {
// If $e is a comment question, and it is not inside a group, there will be no closestPage.
const referer = e.querySelector('[data-for]');
const ancestor = e.closest('.or-repeat, form.or');
if (referer && ancestor) {
Expand Down
Loading
Loading