Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed editing display of uploaded file with # character in it #212

Conversation

gushil
Copy link

@gushil gushil commented Sep 10, 2024

Closes #204 and https://jira.openclinica.com/browse/OC-22815

I have verified this PR works with

  • Online form submission
  • Offline form submission
  • Saving offline drafts
  • Loading offline drafts
  • Editing submissions
  • Form preview
  • None of the above

What else has been done to verify that this works as intended?

  • Passed all unit tests
  • Manual testing

Why is this the best possible solution? Were any other approaches considered?

  • Using express.js middleware to filter URL, as @MartijnR suggests.
  • Simple yet working solultion.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

None.

Do we need any specific form for testing your changes? If so, please attach one.

Just usual form with file upload item.

@svadla-oc svadla-oc merged commit a1914cd into OpenClinica:main Sep 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filepicker issue with filename character
2 participants