Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: User can paste value into read-only date field #213

Merged

Conversation

gushil
Copy link

@gushil gushil commented Oct 4, 2024

Closes https://jira.openclinica.com/browse/OC-23583

I have verified this PR works with

  • Online form submission
  • Offline form submission
  • Saving offline drafts
  • Loading offline drafts
  • Editing submissions
  • Form preview
  • None of the above

What else has been done to verify that this works as intended?

Unit tests passed
Manual tests

Why is this the best possible solution? Were any other approaches considered?

Backend changes not possible because of edit-url relationship, so frontend changes is the one.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

None. Minimal changes that solve the problem.

Do we need any specific form for testing your changes? If so, please attach one.

No. Just usual date field in a form.

@svadla-oc svadla-oc merged commit 4ef5f28 into OpenClinica:main Oct 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants