Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove temp workaround for pages #5

Merged
merged 1 commit into from
May 13, 2024

Conversation

MartijnR
Copy link
Member

Closes # #26

This removes the temporary workaround because it is no longer required.

@MartijnR MartijnR requested a review from gushil April 17, 2024 20:59
@MartijnR MartijnR changed the base branch from main to fix/repeat-customization-refactoring May 1, 2024 14:03
@MartijnR MartijnR changed the base branch from fix/repeat-customization-refactoring to main May 1, 2024 14:03
@MartijnR
Copy link
Member Author

MartijnR commented May 1, 2024

@gushil, I had to 'Edit', swap to another base, and then swap back to the 'main' base for this PR to update the diff. Now it is showing just the single commit. It's weird, I thought GitHub always updated automatically in the past. Maybe I'm misremembering because it is a little unusual to stack PRs on top of other PRs (in this case, it is better though imo).

@gushil
Copy link

gushil commented May 8, 2024

@gushil, I had to 'Edit', swap to another base, and then swap back to the 'main' base for this PR to update the diff. Now it is showing just the single commit. It's weird, I thought GitHub always updated automatically in the past. Maybe I'm misremembering because it is a little unusual to stack PRs on top of other PRs (in this case, it is better though imo).

That is weird. Yes, now it looks 'right'.

Thanks!

@MartijnR MartijnR merged commit d93220e into main May 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants