UI: Refactoring the current ToU widget to the new controller #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ToU controller implemented.
# Conflicts: # ui/src/app/edge/history/history.component.html # ui/src/app/edge/live/live.module.ts
|
|
lukasrgr
requested changes
Aug 10, 2023
|
|
|
|
lukasrgr
approved these changes
Aug 11, 2023
|
@lukasrgr / @venu-sagar: Is this ready to be merged? It should anyway work independently of #2238 to stay backwards compatible, right? Please add me as reviewer if required - otherwise it is really hard to keep track of finished developments. Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the current ToU widgets according to the new controller implemented in #2238
Should be merged with #2238