fix: upgrade gradle version 8.4 to 8.5 #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for digging into this! According to https://github.com/gradle/gradle/releases/tag/v8.5.0 the official way to upgrade gradle is via:
This command not only updates Thanks & Regards, |
|
Thank you feedback! Its very helpful information to me because I'm not familiar with java-related ecosystem. |
gradle versions up to 8.4 has chacing-problem and In openms, build-clean-build steps fails by last build. https://github.com/girasolenergy/openems-fork/actions/runs/7206191185/job/19630540280 This changes fix the problem by updating gradle version 8.4 to 8.5 Test is here. it work. https://github.com/girasolenergy/openems-fork/actions/runs/7282794004/job/19845714357 See also - OpenEMS#2458 - gradle/gradle#20830 > ./gradlew wrapper --gradle-version=8.5
miettal
force-pushed
the
bugfix/update-gradle8.4-to-8.5
branch
from
535451e
to
36d172d
Compare
|
|
|
@sfeilmeier I updated commit by following command. could you review it? |
sfeilmeier
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2458
gradle versions up to 8.4 has caching-problem and
In openms, build-clean-build steps fails by last build step.
https://github.com/girasolenergy/openems-fork/actions/runs/7206191185/job/19630540280
This changes fix the problem by updating gradle version 8.4 to 8.5
Test is here. it work.
https://github.com/girasolenergy/openems-fork/actions/runs/7282794004/job/19845714357
See also