-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: evcs cluster widget missing alias #2807
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files@@ Coverage Diff @@
## develop #2807 +/- ##
=============================================
+ Coverage 56.01% 56.65% +0.65%
- Complexity 8197 8922 +725
=============================================
Files 2103 2167 +64
Lines 89017 91959 +2942
Branches 6560 6831 +271
=============================================
+ Hits 49853 52093 +2240
- Misses 37446 37990 +544
- Partials 1718 1876 +158 |
@Jasonlee6789 default is a empty string right now, openems/io.openems.edge.evcs.cluster/src/io/openems/edge/evcs/cluster/Config.java Line 16 in 7ef6c74
so it is possible that the title is not set, it would be better if we touch the edge config instead, then we can also get rid of the
FYI @sebastianasen wasnt there a general change in aliases not being empty but taking the id as default? |
If this previous international alias doesn't display, I find the bug is that we should use || replace ??, I have tried ||, it works, I will make a new commit. |
Before
After