Invert siemens pac1600 #2821
Closed
Invert siemens pac1600 #2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction and consumption energy register. These were swapped.
Codecov ReportAttention: Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2821 +/- ##
=============================================
- Coverage 56.01% 56.01% -0.00%
- Complexity 8197 8200 +3
=============================================
Files 2103 2103
Lines 89017 89050 +33
Branches 6560 6561 +1
=============================================
+ Hits 49853 49870 +17
- Misses 37446 37460 +14
- Partials 1718 1720 +2 |
Changes the position of a bracket because it caused an error in the build check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the invert task of Siemens PAC 1600 and corrected the production and consumption energy register. These were swapped. It also implement the SCALE_FACTOR_MINUS_2_AND_INVERT, because it hasn't exist.