Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Masonry layout for widgets #2845

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

da-Kai
Copy link
Contributor

@da-Kai da-Kai commented Oct 18, 2024

Aktuell

Bildschirmfoto am 2024-10-18 um 18 02 25

Masonry Layout

Bildschirmfoto am 2024-10-18 um 18 01 06

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2845      +/-   ##
=============================================
+ Coverage      56.11%   56.65%   +0.54%     
- Complexity      8545     8919     +374     
=============================================
  Files           2140     2167      +27     
  Lines          90538    91964    +1426     
  Branches        6717     6831     +114     
=============================================
+ Hits           50795    52089    +1294     
- Misses         37985    38000      +15     
- Partials        1758     1875     +117     

@da-Kai
Copy link
Contributor Author

da-Kai commented Oct 25, 2024

@lukasrgr
Ich hab die Implementierung jetzt so geändert, dass die reihenfolge gleich bleibt

openems-masonry

@Sn0w3y
Copy link
Contributor

Sn0w3y commented Nov 15, 2024

Just a little Information for you @da-Kai - I tried this and it basically scrumbled up sometimes all Widgets as they got rendered too slow because of the slower Channel Population of some Components - either we need to increase the Timeout here:

https://github.com/OpenEMS/openems/pull/2845/files#diff-b001e10dc95932dfad86e0e988df71e34fafc7fa94c3457d65707af3d19f8a07R49

or find another solution for it i guess ? :)

Edit: The CSS does not get applied correctly if the Container is getting bigger after Channel Population. This leads to Overlapping Cards for example. I also got it from time to Time, that the Cards were just above each other on the top left upper corner, where nothing could be seen anymore. JFYI

Greetings !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants