FEMS Backports 2024-11-01 #2863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed lables shown below. -> Energy is represented as Power. -> Entladung/Beladung is represented as Charge/Discharge power. replaced with Just Charge/Discharge. Co-authored-by: Lukas Rieger <[email protected]> Reviewed-by: Lukas Rieger <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Sagar Venu <[email protected]> Co-committed-by: Sagar Venu <[email protected]>
- Added Tests to identify when and how the exception can occur. - Tests for the "calculateCycleTime" work for multiple cases without throwing an exception - Tests could still be kept for code coverage Co-authored-by: Sebastian Asen <[email protected]> Co-authored-by: Stefan Feilmeier <[email protected]> Reviewed-by: Sebastian Asen <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Johann Kaufmann <[email protected]> Co-committed-by: Johann Kaufmann <[email protected]>
- Change the serial number filter according to the goowe serial number rule. - Each GoodWe Type is now detected individually by its rated power in combination with its internal model series code. Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Sebastian Asen <[email protected]> Co-committed-by: Sebastian Asen <[email protected]>
- Added Listener to ActivePowerLX Channels - Each Listeners checks if the nextValue for the power channel if the current and power have the same sign - If the sign is different the current channel is set with * -1 Co-authored-by: Stefan Feilmeier <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Johann Kaufmann <[email protected]> Co-committed-by: Johann Kaufmann <[email protected]>
- `DummyModbusBridge` can now be used to test raw modbus reads - Apply new test for changes in GoodWe GridMeter and SunSpec Also: - Improve and apply `ReflectionUtils` Reviewed-by: Sebastian Asen <[email protected]>
Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Sagar Venu <[email protected]> Co-committed-by: Sagar Venu <[email protected]>
- Added OS_VERSION Channel in Host Component - Write e. g. "11 (bullseye)" in channel for linux and for windows "Windows 11" Reviewed-by: Kai Jeschek <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Michael Grill <[email protected]> Co-committed-by: Michael Grill <[email protected]>
- Start recommended restructuring observables to signals - Fix `UserComponent` caching user information after logout Reviewed-by: Sagar Venu <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Lukas Rieger <[email protected]> Co-committed-by: Lukas Rieger <[email protected]>
- Auto capitalize ibn-installer key input field to show only upper case letters in mobile view (keyboard) - Fix wrong service number in offline manuals - adjust time of use chart in live with replacing the upper most left yAxis tick with the chart title Reviewed-by: Hanna Späth <[email protected]> Reviewed-by: Sagar Venu <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Lukas Rieger <[email protected]> Co-committed-by: Lukas Rieger <[email protected]>
- Improving app center readability of icons Reviewed-by: Michael Grill <[email protected]> Co-authored-by: Lukas Rieger <[email protected]> Co-committed-by: Lukas Rieger <[email protected]>
Co-authored-by: Michael Grill <[email protected]> Reviewed-by: Michael Grill <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Sagar Venu <[email protected]> Co-committed-by: Sagar Venu <[email protected]>
Codecov ReportAttention: Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2863 +/- ##
=============================================
+ Coverage 56.66% 56.84% +0.18%
- Complexity 8926 9050 +124
=============================================
Files 2167 2171 +4
Lines 91959 92271 +312
Branches 6831 6848 +17
=============================================
+ Hits 52103 52441 +338
+ Misses 37981 37910 -71
- Partials 1875 1920 +45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DummyModbusBridgecan now be used to test raw modbus readsReflectionUtils_host/OsVersion: read os version as stringUserComponentcaching user information after logoutCo-authored-by: Lukas Rieger [email protected]
Co-authored-by: Sagar Venu [email protected]
Co-authored-by: Sebastian Asen [email protected]
Co-authored-by: Stefan Feilmeier [email protected]
Co-authored-by: Johann Kaufmann [email protected]
Co-authored-by: Michael Grill [email protected]