Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove version name and upload files #503

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Conversation

mikemhenry
Copy link
Contributor

@mikemhenry mikemhenry commented Jul 25, 2023

Developers certificate of origin

Still need to keep #464 but this will make it so our "latest" trick for the release works and now you don't need to download the assets. All that we have left to do is figure out how we want to automate this being triggered when we get a new conda-forge release

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2d0fdad) 91.72% compared to head (bd481b8) 91.72%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #503   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files         110      110           
  Lines        6607     6607           
=======================================
  Hits         6060     6060           
  Misses        547      547           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dwhswenson dwhswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe add a comment to mention that much of this is heavily influenced by the miniforge workflows? (just with the thought that if we ever have a problem in the future, we know where to go to see if they already solved the problem)

Otherwise, merge at will!

@mikemhenry
Copy link
Contributor Author

Good idea, I will add a link to the inspo

@mikemhenry mikemhenry enabled auto-merge (squash) July 25, 2023 21:20
@mikemhenry mikemhenry merged commit 02d5b53 into main Jul 26, 2023
6 checks passed
@mikemhenry mikemhenry deleted the feat/automate_release_assets branch July 26, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants