-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
see if py311 works okay #508
Conversation
Inspired by #507 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
=======================================
Coverage 91.81% 91.81%
=======================================
Files 110 110
Lines 6681 6681
=======================================
Hits 6134 6134
Misses 547 547 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like 3.11 works. I vote to include it in our testing matrix. Also means that wasn't the problem in #507.
O we probably should limit Macos to a single runner but if this auto merges first we can do it later |
Okay if we only want to run a job on OSX, which python version do we want it to be? I can do that on this PR. |
Maybe just the latest? So python 3.11 on osx but skip the others? Or do we want to keep the oldest and the newest and just skip 3.10? |
3.11 only is fine, that's what folks will pick up on a clean install. |
Got all the branch checks setup now as well |
Developers certificate of origin