Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update network layout to use graphviz #523

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Conversation

richardjgowers
Copy link
Contributor

@richardjgowers richardjgowers commented Aug 16, 2023

fixes issue #522

Developers certificate of origin

@richardjgowers
Copy link
Contributor Author

Before:
Screenshot_20230816_105040

After:
Screenshot_20230816_104959

Also seems to be deterministic now

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ff7bb16) 92.01% compared to head (e667856) 92.01%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #523   +/-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files         113      113           
  Lines        6850     6850           
=======================================
  Hits         6303     6303           
  Misses        547      547           
Files Changed Coverage Δ
openfe/utils/network_plotting.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay
Copy link
Member

IAlibay commented Aug 17, 2023

@richardjgowers am I correct in assuming this doesn't break anything in the interative layer?

@richardjgowers
Copy link
Contributor Author

richardjgowers commented Aug 17, 2023 via email

@IAlibay IAlibay merged commit e420b67 into main Aug 17, 2023
7 checks passed
@IAlibay IAlibay deleted the issue_522_network_layouts branch August 17, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants