-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes implementation of transmuting_methyl_into_ring_score #526
Conversation
previously would penalise H to ring atom contributions. this will affect the results of `default_lomap_score` function
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #526 +/- ##
==========================================
+ Coverage 92.01% 92.10% +0.09%
==========================================
Files 113 113
Lines 6850 6930 +80
==========================================
+ Hits 6303 6383 +80
Misses 547 547
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small things ottherwise lgtm!
@@ -291,10 +291,11 @@ def creates_heterocyle(mol): | |||
|
|||
def transmuting_methyl_into_ring_score(mapping: LigandAtomMapping, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to ask this, but could you add a direct test for this here? It'll help document intentions in the future.
@@ -291,10 +291,11 @@ def creates_heterocyle(mol): | |||
|
|||
def transmuting_methyl_into_ring_score(mapping: LigandAtomMapping, | |||
beta=0.1, penalty=6.0): | |||
"""Penalises ring forming | |||
"""Penalises having a non-mapped ring atoms become a non-ring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"""Penalises having a non-mapped ring atoms become a non-ring | |
"""Penalises having a non-mapped ring atoms become a non-ring group |
Or something like that.
now complete parity with Lomap implementation
previously would penalise H to ring atom contributions.
this will affect the results of
default_lomap_score
functionDevelopers certificate of origin