-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix RTHP results serialization and test results load #550
Changes from all commits
3933726
d30cb16
301b648
28f530d
e2428c7
394f847
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think I'm missing something really obvious. I'm trying to load in the results json back into a Current testing looks something like this:
Looks like it hasn't sufficiently deserialized the protocol unit results, is this even something we're meant to be able to do? Loads fine, has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these be
int
instead offloat
? (Variable name looks to me like anint
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've already raised that issue in openmmtools, currently they return float and it's been agreed that they will eventually change.