Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup mypy matplotlib #575

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Fixup mypy matplotlib #575

merged 5 commits into from
Oct 10, 2023

Conversation

richardjgowers
Copy link
Contributor

Developers certificate of origin

@pep8speaks
Copy link

pep8speaks commented Oct 10, 2023

Hello @richardjgowers! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 250:80: E501 line too long (85 > 79 characters)
Line 256:80: E501 line too long (88 > 79 characters)
Line 257:80: E501 line too long (84 > 79 characters)
Line 258:80: E501 line too long (88 > 79 characters)

Comment last updated at 2023-10-10 08:13:15 UTC

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ab0ae26) 91.29% compared to head (a43daec) 91.32%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #575      +/-   ##
==========================================
+ Coverage   91.29%   91.32%   +0.02%     
==========================================
  Files         117      117              
  Lines        7287     7300      +13     
==========================================
+ Hits         6653     6667      +14     
+ Misses        634      633       -1     
Files Coverage Δ
openfe/analysis/plotting.py 100.00% <100.00%> (ø)
...enfe/protocols/openmm_utils/multistate_analysis.py 93.07% <100.00%> (ø)
openfe/utils/network_plotting.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richardjgowers richardjgowers merged commit 6ce00dd into main Oct 10, 2023
9 checks passed
@richardjgowers richardjgowers deleted the fixup_mypy_matplotlib branch October 10, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants