Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pymbar duecredit #753

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Pymbar duecredit #753

merged 4 commits into from
Jul 29, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Mar 4, 2024

Fixes #607

Checklist

  • Added a news entry

Developers certificate of origin

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.37%. Comparing base (dd0be23) to head (6decdca).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     OpenFreeEnergy/openfe#753      +/-   ##
==========================================
- Coverage   94.17%   92.37%   -1.81%     
==========================================
  Files         134      134              
  Lines        9800     9806       +6     
==========================================
- Hits         9229     9058     -171     
- Misses        571      748     +177     
Flag Coverage Δ
fast-tests 92.37% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikemhenry mikemhenry enabled auto-merge (squash) July 26, 2024 18:32
@mikemhenry mikemhenry disabled auto-merge July 29, 2024 14:47
@mikemhenry
Copy link
Contributor

mikemhenry commented Jul 29, 2024

RTD is failing but unrelated to this PR, merging in, see OpenFreeEnergy/ofe-sphinx-theme#5

@mikemhenry mikemhenry merged commit ba4d892 into main Jul 29, 2024
11 of 12 checks passed
@mikemhenry mikemhenry deleted the pymbar_duecredit branch July 29, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pymbar citations to duecredit
2 participants