Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin macos runners to macos-12 #841

Merged
merged 4 commits into from
Apr 27, 2024
Merged

pin macos runners to macos-12 #841

merged 4 commits into from
Apr 27, 2024

Conversation

mikemhenry
Copy link
Contributor

@mikemhenry mikemhenry commented Apr 25, 2024

Checklist

  • Added a news entry

Developers certificate of origin

@mikemhenry mikemhenry requested a review from IAlibay April 25, 2024 02:16
@mikemhenry
Copy link
Contributor Author

I think we should make macos-latest not a required check until we get the missing deps onto conda-forge, but we should keep it in the build matrix.

We should make macos-13 a required check.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.32%. Comparing base (378147c) to head (059ceda).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #841      +/-   ##
==========================================
- Coverage   94.13%   92.32%   -1.81%     
==========================================
  Files         134      134              
  Lines        9786     9786              
==========================================
- Hits         9212     9035     -177     
- Misses        574      751     +177     
Flag Coverage Δ
fast-tests 92.32% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemhenry
Copy link
Contributor Author

We got one missing dep, a weird package hash error, and a issue with ambertools/charge backend :)

@IAlibay IAlibay changed the title use x86 runners and m1 runners of osx use x86 runners for osx Apr 25, 2024
@IAlibay
Copy link
Member

IAlibay commented Apr 25, 2024

@mikemhenry for the sake of "getting CI back and running today", let's go with just pinning to macos-13. I've opened a separate issue to deal with arm64-osx in a separate PR.

Something seems to be pulling AT22
@IAlibay IAlibay changed the title use x86 runners for osx pin macos runners to macos-12 Apr 26, 2024
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-approving

@IAlibay IAlibay merged commit 73396c0 into main Apr 27, 2024
9 of 10 checks passed
@IAlibay IAlibay deleted the fix/use_x86_mac_os_runners branch April 27, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants