-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin macos runners to macos-12 #841
Conversation
I think we should make We should make macos-13 a required check. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #841 +/- ##
==========================================
- Coverage 94.13% 92.32% -1.81%
==========================================
Files 134 134
Lines 9786 9786
==========================================
- Hits 9212 9035 -177
- Misses 574 751 +177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We got one missing dep, a weird package hash error, and a issue with ambertools/charge backend :) |
@mikemhenry for the sake of "getting CI back and running today", let's go with just pinning to macos-13. I've opened a separate issue to deal with arm64-osx in a separate PR. |
Something seems to be pulling AT22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self-approving
Checklist
news
entryDevelopers certificate of origin