Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Test python 3.12 #850

Closed
wants to merge 21 commits into from
Closed

[DNM] Test python 3.12 #850

wants to merge 21 commits into from

Conversation

mikemhenry
Copy link
Contributor

Checklist

  • Added a news entry

Developers certificate of origin

@pep8speaks
Copy link

pep8speaks commented May 10, 2024

Hello @mikemhenry! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 253:5: E303 too many blank lines (2)

Comment last updated at 2024-05-10 19:40:45 UTC

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.28%. Comparing base (e8492ea) to head (3655ef1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
- Coverage   93.09%   92.28%   -0.81%     
==========================================
  Files         134      134              
  Lines        9708     9804      +96     
==========================================
+ Hits         9038     9048      +10     
- Misses        670      756      +86     
Flag Coverage Δ
fast-tests 92.28% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemhenry
Copy link
Contributor Author

okay it looks like because of 56bd856 we had a numpy<1.24 pin, but that was just in our env and not the conda package, so if we don't have any issues we should have python 3.12 support

@mikemhenry
Copy link
Contributor Author

mikemhenry commented May 10, 2024

we just need conda-forge/citeproc-py-feedstock#9 for osx-latest/osx-arm64 (or at least that is what is currently blocking that)

@mikemhenry
Copy link
Contributor Author

Okay! So I learned we can support python 3.12 and we are maybe a PR away from supporting osx-arm64 in our CI

@mikemhenry mikemhenry closed this May 10, 2024
@mikemhenry mikemhenry deleted the test_python_3.12 branch October 4, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants