-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] Test python 3.12 #850
Conversation
Co-authored-by: Hannah Baumann <[email protected]>
Hello @mikemhenry! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-05-10 19:40:45 UTC |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #850 +/- ##
==========================================
- Coverage 93.09% 92.28% -0.81%
==========================================
Files 134 134
Lines 9708 9804 +96
==========================================
+ Hits 9038 9048 +10
- Misses 670 756 +86
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
okay it looks like because of 56bd856 we had a numpy<1.24 pin, but that was just in our env and not the conda package, so if we don't have any issues we should have python 3.12 support |
we just need conda-forge/citeproc-py-feedstock#9 for osx-latest/osx-arm64 (or at least that is what is currently blocking that) |
Okay! So I learned we can support python 3.12 and we are maybe a PR away from supporting osx-arm64 in our CI |
Checklist
news
entryDevelopers certificate of origin