Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add osx-arm64 py312 test #853

Merged
merged 2 commits into from
May 16, 2024
Merged

add osx-arm64 py312 test #853

merged 2 commits into from
May 16, 2024

Conversation

mikemhenry
Copy link
Contributor

@mikemhenry mikemhenry commented May 16, 2024

Checklist

  • Added a news entry

Developers certificate of origin

@mikemhenry
Copy link
Contributor Author

Now that conda-forge/citeproc-py-feedstock#9 is merged we should be able to run on osx-arm64

@mikemhenry
Copy link
Contributor Author

Looks like the issue was with duecredit 0.10.0, not the new py-cite build that got merged 😅 (thought I broke the whole duecredit ecosystem)

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.28%. Comparing base (5be7f73) to head (21b589c).
Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
- Coverage   94.05%   92.28%   -1.77%     
==========================================
  Files         134      134              
  Lines        9804     9804              
==========================================
- Hits         9221     9048     -173     
- Misses        583      756     +173     
Flag Coverage Δ
fast-tests 92.28% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemhenry mikemhenry requested a review from IAlibay May 16, 2024 16:39
@mikemhenry
Copy link
Contributor Author

🎉 we don't technically need the CONDA_SUBDIR=osx-64 anymore, but I think until we test like our notebooks or cli tutorial we should keep the work around in our docs.

@mikemhenry
Copy link
Contributor Author

Since this is just expanding our testing matrix, I am going to merge this in

@mikemhenry mikemhenry merged commit acada80 into main May 16, 2024
12 checks passed
@mikemhenry mikemhenry deleted the test_py312_osx_arm64 branch May 16, 2024 16:51
@mikemhenry
Copy link
Contributor Author

mikemhenry commented May 16, 2024

OH and the latest version of duecredit seems broken, I've reported it upstream and fixed the pin
duecredit/duecredit#214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant