Fix for 2 bugs in the fastq reader: #497
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- \r\n handling may cause reading a byte past end of buffer, parser fails - checking end-of-file condition can only be reliably done after a call to getLine() returns NULL. One particular case is that some gzip files contain empty gzip blocks at the end of the file, which can´t be predicted by the current eof() code Tested with files provided in issue OpenGene#491. This reverts commit 0ee1b3b, "fix a regression bug of FASTQ reader"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0ee1b3b, "fix a regression bug of FASTQ reader"