Extend zero writes after end of append context to ensure the complete… #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… next header (int + any padding offset) is guaranteed to be 0 (NONE/EOF)
rogersimmons
requested review from
JerryShea,
peter-lawrey,
RobAustin and
nicktindall
nicktindall
approved these changes
May 30, 2022
JerryShea
approved these changes
May 30, 2022
|
Can we add to IncompleteMessageTest to reproduce the issue? It seems to have existed since February and not failed so I assume it doesn't cover this case. |
JerryShea
pushed a commit
that referenced
this pull request
Jun 12, 2022
… next header (int + any padding offset) is guaranteed to be 0 (NONE/EOF) (#481) Co-authored-by: rogersimmons <[email protected]>
|
See also #496 which is the backport to 22 |
JerryShea
pushed a commit
that referenced
this pull request
Jun 13, 2022
… next header (int + any padding offset) is guaranteed to be 0 (NONE/EOF) (#481) Co-authored-by: rogersimmons <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Queue issue OpenHFT/Chronicle-Queue#1099