Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapping up datatypes part 1 #1029

Conversation

madprime
Copy link
Member

@madprime madprime commented Apr 13, 2019

Description

Opening a PR for my work so it can be reviewed, because I might be impaired by opioid drugs.

Related Issue

Here's a list of TODO items we still want:

  • Dropdown in form for submitting/editing datatypes needs to be ordered
  • Show "see full list" all the time, not just when there's no parent
  • List of DataTypes per project should be filtered on approved projects
  • Project setup description/docs need to include guide for registering data types
  • 'Manage projects' redesigned to have one "manage project" button & name linked to activity page

Originally posted by @madprime in #1026 (comment)

Testing

  • pass automated tests
  • manually testing each item locally

@madprime madprime changed the title WIP: wrapping up datatypes part 1 Wrapping up datatypes part 1 Apr 15, 2019
@madprime madprime requested a review from mldulaney April 15, 2019 16:46
Copy link
Contributor

@mldulaney mldulaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment, as noted in Slack, is that there is not a way to return to the select datatypes for a project page if one goes to add a datatype.

Otherwise, looks skookum here!

@madprime madprime merged commit d5f3fc2 into OpenHumans:201904-feature-datafile-datatypes Apr 15, 2019
@madprime madprime deleted the 201904-feature-datafile-datatypes branch April 15, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants